-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add new exported function GetCellPixelsWithCoordinates
#1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
t4traw
wants to merge
17
commits into
qax-os:master
Choose a base branch
from
t4traw:feature-get-cell-pixels-with-coordinates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add new exported function GetCellPixelsWithCoordinates
#1842
t4traw
wants to merge
17
commits into
qax-os:master
from
t4traw:feature-get-cell-pixels-with-coordinates
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79958aa
to
0c3dfb1
Compare
Hi @xuri |
…e exceeds 4GB - Update unit tests - Support set version required to 4.5 in local file header - Note that this fix not work on Office 2010
- Rows iterator speedup about 20%, memory allocation reduce about 10% - Update unit test - Extends time out to 50 minutes in GitHub Action for made TestZip64 stable
- Add ShowDataTable and ShowDataTableKeys fields in the ChartPlotArea data type - Update unit tests
…lculation (qax-os#2118) - Reuse formula shared index when update refer cell formula - Fix shared cell not been updated on update refer cell formula with new range - Upgrade dependencies package go-deepcopy to v1.5.2 - Update unit tests
… formula reference code
…ts no longer affect the image size (qax-os#2123) - Change default column width from 9.140625 to 10.5 - Change default column width in pixels from 64 to 84 - Change default row height from 15 to 15.6 - Change default row height in pixels from 20 to 20.8 - Change column width and row height to pixels conversion calculation logic - Support to insert one cell anchor image when specified the positioning as "oneCell"
…ename sheet (qax-os#2127) - Update unit tests
…one cell anchor drawing object (qax-os#2128) * Fix absolute positioning to-point error and adjust one cell anchor drawing object failed * Revert default column width and row height * Clean shared formula cell cache before remvoe it in calc chain * Revert adjustFormulaRef changes in the commit 3ccbdaa * Update unit tests * Format code
- Update unit tests
…hen remove row - Add unit tests - Update dependencies modules
…mmit ce9061f - Update GitHub Action configuration for test build on ARM
…ist (qax-os#2137) - Support delete data validation by given with multiple cell ranges with reference sequence slice or blank separated reference sequence string - Update unit tests
…ub.com/t4traw/excelize into feature-get-cell-pixels-with-coordinates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Added
GetCellPixelsWithCoordinates
Function to Determine Cell Dimensions in PixelsRelated Issue
#1813
Motivation and Context
To adjust the aspect ratio displayed in individual Excel cells, it is necessary to tweak ScaleX or ScaleY, but there isn't an appropriate public function available for this calculation. Although public functions like GetRowHeight and GetColWidth exist, they do not return values in pixels, and there's a discrepancy with the pixel calculations used within drawingResize in AddPicture. DrawingResize (using getRowHeight and getColWidth) seems to accurately calculate sizes for the most part.
Therefore, the pixel function used in drawingResize has been extracted as a public function.
How Has This Been Tested
Types of changes
Checklist